domains: emit uncaughtException when appropriate #3637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nodejs/lts @nodejs/collaborators @nodejs/tsc. |
| * given test tests one of these potentially eroneous behaviors that are | ||
| * currently accepted as correct. | ||
| */ | ||
|
|
misterdjules
force-pushed
the
fix-issue-3607
branch
2 times, most recently
from
64e8643
to
e974362
Compare
misterdjules
force-pushed
the
fix-issue-3607
branch
from
69a0ae3
to
e077d2c
Compare
|
Pushed a second commit in this PR that fixes #3653. It changes the API of |
misterdjules
force-pushed
the
fix-issue-3607
branch
from
e077d2c
to
a72719d
Compare
added 2 commits
November 4, 2015 14:20
Fix node exiting due to an exception being thrown rather than emitting an `'uncaughtException'` event on the process object when no error handler is set on the domain within which an error is thrown and an `'uncaughtException'` event listener is set on the process. Fixes nodejs#3607.
Make the process abort if an error is thrown within a domain with no error handler and `--abort-on-uncaught-exception` is used. If the domain within which the error is thrown has no error handler, but a domain further down the domains stack has one, the process will not abort. Fixes nodejs#3653.
misterdjules
force-pushed
the
fix-issue-3607
branch
from
a72719d
to
e7e1dfd
Compare
|
Closing in favor of #3887. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix node exiting due to an exception being thrown rather than emitting
an
'uncaughtException'event on the process object when no errorhandler is set on the domain within which an error is thrown and an
'uncaughtException'event listener is set on the process.Fixes #3607.