Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typographical error #3644

Closed
wants to merge 1 commit into from
Closed

doc: fix typographical error #3644

wants to merge 1 commit into from

Conversation

mccraveiro
Copy link

No description provided.

@Fishrock123
Copy link
Contributor

@mccraveiro It's like this because it comes from a dependancy, v8. And as such should be upstreamed to that project before landing here. Sending a CL is a little complex, so cc @bnoordhuis

@Fishrock123 Fishrock123 added the v8 engine Issues and PRs related to the V8 dependency. label Nov 3, 2015
@targos
Copy link
Member

targos commented Nov 3, 2015

Thanks, but we don't accept direct changes to dependencies.
This typo has been fixed in upstream's V8 so it will eventually arrive here.

Ref: #3522

@targos targos added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Nov 3, 2015
@Fishrock123
Copy link
Contributor

Closing as per @targos's comment. This will eventually land in a node stable and LTS, but this isn't worth backporting and floating, imo.

@Fishrock123 Fishrock123 closed this Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mccraveiro @Fishrock123 @targos