Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ini in tools/node-lint-md-cli-rollup #36474

Closed
wants to merge 2 commits into from
Closed

tools: update ini in tools/node-lint-md-cli-rollup #36474

wants to merge 2 commits into from

Conversation

MylesBorins
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 10, 2020
@MylesBorins MylesBorins mentioned this pull request Dec 10, 2020
Closed
@MylesBorins
Copy link
Contributor Author

can we please fast-track?

@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34888/

Trott
Trott requested changes Dec 11, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebuild lint-md.js and include the resulting file in the PR for this to have any effect.

@Trott
Copy link
Member

Trott commented Dec 11, 2020

You need to rebuild lint-md.js and include the resulting file in the PR for this to have any effect.

I did that and added it as a second commit to keep this moving. Feel free to squash it to one commit if you want.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34900/

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 11, 2020
MylesBorins added a commit that referenced this pull request Dec 11, 2020
@MylesBorins
tools: update ini in tools/node-lint-md-cli-rollup
7faeddf 
Refs: #36473
Refs: GHSA-qqgx-2p2h-9c37

PR-URL: #36474
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MylesBorins
Copy link
Contributor Author

landed in 7faeddf

targos pushed a commit that referenced this pull request Dec 21, 2020
@MylesBorins @targos
tools: update ini in tools/node-lint-md-cli-rollup
c6e65d0 
Refs: #36473
Refs: GHSA-qqgx-2p2h-9c37

PR-URL: #36474
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@MylesBorins @targos
tools: update ini in tools/node-lint-md-cli-rollup
c8f77f2 
Refs: #36473
Refs: GHSA-qqgx-2p2h-9c37

PR-URL: #36474
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@MylesBorins @danielleadams
tools: update ini in tools/node-lint-md-cli-rollup
daee82a 
Refs: #36473
Refs: GHSA-qqgx-2p2h-9c37

PR-URL: #36474
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MylesBorins @nodejs-github-bot @Trott @aduh95