Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use correct outer Context’s microtask queue #36482

Closed
wants to merge 3 commits into from
Closed

src: use correct outer Context’s microtask queue #36482

wants to merge 3 commits into from

Commits on Dec 11, 2020

  1. deps: V8: backport 4bf051d536a1 

    Original commit message:

    [api] Add Context::GetMicrotaskQueue method

    Add a method that returns the microtask queue that is being used
    by the `v8::Context`.

    This is helpful in non-monolithic embedders like Node.js, which
    accept Contexts created by its own embedders like Electron, or
    for native Node.js addons. In particular, it enables:

    1. Making sure that “nested” `Context`s use the correct microtask
       queue, i.e. the one from the outer Context.
    2. Enqueueing microtasks into the correct microtask queue.

    Previously, these things only worked when the microtask queue for
    a given Context was the Isolate’s default queue.

    As an alternative, I considered adding a way to make new `Context`s
    inherit the queue from the `Context` that was entered at the time
    of their creation, but that seemed a bit more “magic”, less flexible,
    and didn’t take care of concern 2 listed above.

    Change-Id: I15ed796df90f23c97a545a8e1b30a3bf4a5c4320
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2579914
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71710}

Refs: v8/v8@4bf051d
    @addaleax
    addaleax committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    090a3f6 View commit details
    Browse the repository at this point in the history

  2. src: use correct outer Context’s microtask queue 

    Fall back to using the outer context’s microtask queue, rather than
the Isolate’s default one. This would otherwise result in surprising
behavior if an embedder specified a custom microtask queue for the
main Node.js context.
    @addaleax
    addaleax committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    299c63d View commit details
    Browse the repository at this point in the history

  3. fixup! src: use correct outer Context’s microtask queue

    @addaleax
    addaleax committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    bde7245 View commit details
    Browse the repository at this point in the history