Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: remove handles when disconnecting worker #3677

Merged
merged 1 commit into from
Nov 6, 2015

Commits on Nov 6, 2015

  1. cluster: remove handles when disconnecting worker

    Due to the race window between the master's "disconnect" message and the
    worker's "handle received" message, connections sometimes got stuck in
    the pending handles queue when calling `worker.disconnect()` in the
    master process.
    
    The observable effect from the client's perspective was a TCP or HTTP
    connection that simply stalled.  This commit fixes that by closing open
    handles in the master when the "disconnect" message is sent.
    
    Fixes: nodejs#3551
    PR-URL: nodejs#3677
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bnoordhuis committed Nov 6, 2015
    1 Configuration menu
    Copy the full SHA
    33827e3 View commit details
    Browse the repository at this point in the history