Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: fix definitions of URL/SearchParams methods and accessors #36799

Merged
merged 2 commits into from
Feb 13, 2021
Merged

url: fix definitions of URL/SearchParams methods and accessors #36799

merged 2 commits into from
Feb 13, 2021

Commits on Feb 13, 2021

  1. url: move URLSearchParams method definitions 

    PR-URL: nodejs#36799
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    @ExE-Boss @aduh95
    ExE-Boss authored and aduh95 committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    dd5b48a View commit details
    Browse the repository at this point in the history

  2. url: fix definitions of URL/SearchParams methods and accessors 

    This fixes getter and setter names for the WHATWG URL classes, and fixes
a few other inconsistencies with browsers implementations.

Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>

PR-URL: nodejs#36799
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    @ExE-Boss @aduh95
    ExE-Boss authored and aduh95 committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    0dfc0f5 View commit details
    Browse the repository at this point in the history