Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15.x backport] http: refactor to use more primordials #36803

Closed
wants to merge 1 commit into from
Closed

[v15.x backport] http: refactor to use more primordials #36803

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 5, 2021 •
edited
Loading

Backport of #36194
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v15.x labels Jan 5, 2021
@targos
Copy link
Member

targos commented Jan 5, 2021

The commit message should not be changed.
"Backport-PR-URL" will be added when this lands and should refer to this PR

@aduh95
http: refactor to use more primordials
700023f 
PR-URL: nodejs#36194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the http-primordials-backport branch from 01a1688 to 700023f Compare January 5, 2021 17:17
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35457/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35461/

danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@aduh95 @danielleadams
http: refactor to use more primordials
5e499c4 
PR-URL: #36194
Backport-PR-URL: #36803
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams
Copy link
Contributor

Landed in 5e499c4

@aduh95 aduh95 closed this Jan 12, 2021
@aduh95 aduh95 deleted the http-primordials-backport branch January 12, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @targos @nodejs-github-bot @danielleadams