http: refactor ClientRequest destroy #36863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/http |
benjamingr
approved these changes
Jan 10, 2021
benjamingr
reviewed
Jan 10, 2021
| return; | ||
| } | ||
|
|
||
| _destroy(req, err || req[kError]); |
There was a problem hiding this comment.
A bunch of these can be slightly niftier code-style wise (??s etc) but that's pretty dumb to block on.
dnlup
reviewed
Jan 11, 2021
ronag
added
request-ci
github-actions
bot
removed
the
request-ci
|
We have the same failing test (https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/24696/) mentioned in #36868. Let's wait a bit to see if there is news about it. |
|
Landed in e39a3f8 |
ronag
added a commit
that referenced
this pull request
Jan 16, 2021
PR-URL: #36863 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
PR-URL: #36863 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterative work towards cleaning up ClientRequest.