Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve coverage at lib/internal/vm/module.js #36898

Merged
merged 1 commit into from
Jan 18, 2021
Merged

test: improve coverage at lib/internal/vm/module.js #36898

merged 1 commit into from
Jan 18, 2021

Conversation

juanarbol
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 12, 2021
lpinca
lpinca approved these changes Jan 12, 2021
View reviewed changes
test/parallel/test-vm-module-synthetic.js Outdated Show resolved Hide resolved
@juanarbol juanarbol force-pushed the juanarbol/improve-code-coverage-vm branch from 014d965 to 1a4d73b Compare January 12, 2021 20:40
@juanarbol juanarbol added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 13, 2021
mhdawson
mhdawson approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 14, 2021 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/35548/ ✅

@juanarbol @aduh95
test: improve coverage at lib/internal/vm/module.js
146f0fc 
PR-URL: nodejs#36898
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@aduh95 aduh95 force-pushed the juanarbol/improve-code-coverage-vm branch from 1a4d73b to 146f0fc Compare January 18, 2021 10:48
@aduh95
Copy link
Contributor

aduh95 commented Jan 18, 2021

Landed in 146f0fc

@aduh95 aduh95 merged commit 146f0fc into nodejs:master Jan 18, 2021
@juanarbol juanarbol deleted the juanarbol/improve-code-coverage-vm branch January 19, 2021 16:26
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@juanarbol @ruyadorno
test: improve coverage at lib/internal/vm/module.js
f589bb2 
PR-URL: #36898
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@juanarbol @targos
test: improve coverage at lib/internal/vm/module.js
0d7882b 
PR-URL: #36898
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request May 30, 2021
@juanarbol @targos
test: improve coverage at lib/internal/vm/module.js
94f4660 
PR-URL: #36898
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@juanarbol @targos
test: improve coverage at lib/internal/vm/module.js
0e79a99 
PR-URL: #36898
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@juanarbol @targos
test: improve coverage at lib/internal/vm/module.js
ec4d79e 
PR-URL: #36898
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@juanarbol @nodejs-github-bot @aduh95 @jasnell @lpinca @mhdawson @Lxxyx