Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove non used getter in lib/perf_hooks.js #36907

Closed
wants to merge 1 commit into from
Closed

lib: remove non used getter in lib/perf_hooks.js #36907

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Jan 13, 2021
aduh95
aduh95 reviewed Jan 18, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go ahead and delete all kCount references, it seems we don't use it anymore since #19563.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35624/

@juanarbol juanarbol force-pushed the junarbol/remove-unsued-getter branch from 1f87cab to 8ff80c6 Compare January 19, 2021 02:16
@juanarbol
Copy link
Member Author

juanarbol commented Jan 19, 2021 •
edited
Loading

Sorry @jasnell, I've removed the references to kCount as @aduh95 suggested! (thank you!!), I'll kickstart the CI again

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35627/

@juanarbol @aduh95
lib: remove non used getter in lib/perf_hooks.js
acbd3a4 
PR-URL: nodejs#36907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the junarbol/remove-unsued-getter branch from 8ff80c6 to acbd3a4 Compare January 19, 2021 11:11
@aduh95
Copy link
Contributor

aduh95 commented Jan 19, 2021

Landed in acbd3a4

@aduh95 aduh95 closed this Jan 19, 2021
@juanarbol juanarbol deleted the junarbol/remove-unsued-getter branch January 19, 2021 16:28
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@juanarbol @ruyadorno
lib: remove non used getter in lib/perf_hooks.js
b3ca539 
PR-URL: #36907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@juanarbol @ruyadorno
lib: remove non used getter in lib/perf_hooks.js
743dd8f 
PR-URL: #36907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@juanarbol @targos
lib: remove non used getter in lib/perf_hooks.js
d78e2ed 
PR-URL: #36907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanarbol @nodejs-github-bot @aduh95 @jasnell