Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x Backport] crypto: implement randomuuid #36945

Closed
wants to merge 1 commit into from
Closed

[v14.x Backport] crypto: implement randomuuid #36945

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 15, 2021

Signed-off-by: James M Snell jasnell@gmail.com
Original-PR-URL: #36729

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v14.x labels Jan 15, 2021
@jasnell jasnell changed the title crypto: implement randomuuid [v14.x Backport] crypto: implement randomuuid Jan 15, 2021
@jasnell jasnell added semver-minor PRs that contain new features and should be released in the next minor version. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 15, 2021
@panva panva mentioned this pull request Jan 18, 2021
Closed
7 tasks
@jasnell
Copy link
Member Author

jasnell commented Jan 18, 2021

/cc @nodejs/backporters @nodejs/releasers ...

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35680/

@jasnell jasnell removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2021
jasnell added a commit that referenced this pull request Jan 22, 2021
@jasnell
crypto: implement randomuuid
3aeaaea 
Signed-off-by: James M Snell <jasnell@gmail.com>
Original-PR-URL: #36729
PR-URL: #36945
Reviewed-By: Ben Coe <bencoe@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jan 22, 2021

Landed in 3aeaaea

@jasnell jasnell closed this Jan 22, 2021
@MylesBorins
Copy link
Contributor

@jasnell we usually do some degree of consensus building with @nodejs/lts prior to backporting semver-minor commits and we generally have it back longer than 14 days prior to a backport (more often multiple months).

Is this an experimental feature?

@jasnell
Copy link
Member Author

jasnell commented Jan 23, 2021

Feel free to revert if necessary

@BethGriggs
Copy link
Member

I'm preparing a patch release of v14 for this week (the plan was to keep this one intentionally small to just address some bugs and pull in an npm update). For ease of preparing the patch release - I'll probably temporarily drop the commit from the staging branch and reopen.

If there are no concerns from @nodejs/lts, i'll aim to re-land on staging after the patch release has gone out? The following/February release is scheduled to be a minor (nodejs/Release#567), and by the time of that release it'll probably have been out in v15 for a while (1 month+).

@BethGriggs BethGriggs reopened this Jan 25, 2021
@jasnell
Copy link
Member Author

jasnell commented Feb 22, 2021

@MylesBorins @BethGriggs ... What's the timeline on this landing in 14.x again?

@BethGriggs
Copy link
Member

We do not yet have a volunteer to prepare the next planned release of Node.js 14. The upcoming security release has pushed the schedule out a little too.

We can pull this into staging ready to go out in the next release (which is due to be a minor). But unfortunately the actual release might be a while off, bearing in mind we'll need volunteer(s), and we've previously aimed for 2-3 weeks release candidate phase for minors.

(It's on my list to try and land some commits on v14.x-staging, but I cannot commit the time to preparing the whole release atm.)

@jasnell
Copy link
Member Author

jasnell commented Apr 21, 2021

@nodejs/releasers ... any updates on when this might land in 14.x?

@targos
Copy link
Member

targos commented Apr 21, 2021

@jasnell when someone takes the time to prepare the next semver-minor release.

@jasnell @targos
crypto: implement randomuuid
ab5e466 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#36729
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37654/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37682/

targos pushed a commit that referenced this pull request Apr 25, 2021
@jasnell @targos
crypto: implement randomuuid
08f9130 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36729
Backport-PR-URL: #36945
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@targos
Copy link
Member

targos commented Apr 25, 2021

Landed in 08f9130

@targos targos closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @MylesBorins @BethGriggs @targos @bcoe