Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve coverage for Module getters #36950

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

juanarbol
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 15, 2021
@juanarbol juanarbol force-pushed the juanarbol/getter-code-coverage branch 2 times, most recently from 65f7cba to 3da166f Compare January 15, 2021 17:43
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 17, 2021
@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#36950
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the juanarbol/getter-code-coverage branch from 3da166f to 9e7d1a1 Compare January 18, 2021 11:06
@aduh95
Copy link
Contributor

aduh95 commented Jan 18, 2021

Landed in 9e7d1a1

@aduh95 aduh95 closed this Jan 18, 2021
@aduh95 aduh95 merged commit 9e7d1a1 into nodejs:master Jan 18, 2021
@juanarbol juanarbol deleted the juanarbol/getter-code-coverage branch January 19, 2021 16:26
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
PR-URL: #36950
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
targos pushed a commit that referenced this pull request May 25, 2021
PR-URL: #36950
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #36950
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #36950
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36950
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants