[docs] Fix grammar and link to QUIC #36959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
approved these changes
Jan 16, 2021
dandv
changed the title
This can be fixed when landing, to avoid having to run another CI just to fix the commit message. |
Trott
approved these changes
Jan 16, 2021
There was a problem hiding this comment.
LGTM although I wonder if the link should be https://developer.mozilla.org/en-US/docs/Glossary/QUIC rather than Wikipedia.
PoojaDurgad
approved these changes
Jan 18, 2021
HarshithaKP
approved these changes
Jan 18, 2021
|
@gengjiawen do you want to retract or rephrase your objection? Per our policy, objection must include a clear reason for that objection. |
gengjiawen
reviewed
Jan 18, 2021
My objection is clear. But also this can be fixed by commiter, I have dismissed my objection with a comment. |
RaisinTen
added
the
author ready
aduh95
dismissed
gengjiawen’s stale review
They dismissed their objection in a comment above.
|
Landed in 75a73c4 |
aduh95
pushed a commit
that referenced
this pull request
Jan 18, 2021
PR-URL: #36959 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
PR-URL: #36959 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.