Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixup flaky test-crypto-x509 on windows #36966

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 16, 2021

image

👍🏻 to fast-track

@jasnell jasnell added flaky-test Issues and PRs related to the tests with unstable failures on the CI. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2021
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 16, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 16, 2021
@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2021
@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#36966
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 force-pushed the fix-flaky-x509-test-on-windows branch from 901b0eb to 433afd9 Compare January 16, 2021 23:20
@aduh95
Copy link
Contributor

aduh95 commented Jan 16, 2021

Landed in 433afd9

@aduh95 aduh95 merged commit 433afd9 into nodejs:master Jan 16, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
PR-URL: #36966
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants