Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: refactor to remove redundant validation #36984

Closed
wants to merge 1 commit into from
Closed

fs: refactor to remove redundant validation #36984

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

The function makeCallback already calls validateCallback, so the call
inside copyFile can be removed.

makeCallback is called here:

node/lib/fs.js

Line 2050 in 568b26a

callback = makeCallback(callback);

and makeCallback calls validateCallback here:

node/lib/fs.js

Line 182 in 568b26a

validateCallback(cb);

@RaisinTen
fs: refactor to remove redundant validation
ea76a88 
The function makeCallback already calls validateCallback, so the call
inside copyFile can be removed.
@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Jan 18, 2021
@RaisinTen
Copy link
Contributor Author

cc @nodejs/fs

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35602/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@jasnell
Copy link
Member

jasnell commented Jan 23, 2021

Landed in ae5e95f

@jasnell jasnell closed this Jan 23, 2021
jasnell pushed a commit that referenced this pull request Jan 23, 2021
@RaisinTen @jasnell
fs: refactor to remove redundant validation
ae5e95f 
The function makeCallback already calls validateCallback, so the call
inside copyFile can be removed.

PR-URL: #36984
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RaisinTen RaisinTen deleted the fs/refactor-to-remove-redundant-validation branch January 23, 2021 13:44
targos pushed a commit that referenced this pull request Feb 2, 2021
@RaisinTen @targos
fs: refactor to remove redundant validation
97fc7d8 
The function makeCallback already calls validateCallback, so the call
inside copyFile can be removed.

PR-URL: #36984
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RaisinTen @nodejs-github-bot @jasnell @lpinca @targos @cjihrig @aduh95 @juanarbol