Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve assertion message for test-vm-memleak #37034

Merged
merged 1 commit into from
Jan 25, 2021
Merged

test: improve assertion message for test-vm-memleak #37034

merged 1 commit into from
Jan 25, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 23, 2021

The test is unreliable in CI. It might be helpful to get an exact read
of rss so this adds that to the assertion message.

@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jan 23, 2021
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 23, 2021
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 25, 2021
@Trott
Copy link
Member Author

Trott commented Jan 25, 2021

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/18833/

@Trott
test: improve assertion message for test-vm-memleak
13ac5fb 
The test is unreliable in CI. It might be helpful to get an exact read
of `rss` so this adds that to the assertion message.

PR-URL: nodejs#37034
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 25, 2021

Landed in 13ac5fb

@Trott Trott merged commit 13ac5fb into nodejs:master Jan 25, 2021
@Trott Trott deleted the better-msg branch January 25, 2021 19:26
targos pushed a commit that referenced this pull request Feb 2, 2021
@Trott @targos
test: improve assertion message for test-vm-memleak
074641c 
The test is unreliable in CI. It might be helpful to get an exact read
of `rss` so this adds that to the assertion message.

PR-URL: #37034
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: improve assertion message for test-vm-memleak
ec7ee61 
The test is unreliable in CI. It might be helpful to get an exact read
of `rss` so this adds that to the assertion message.

PR-URL: #37034
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @lpinca @gireeshpunathil @aduh95 @nodejs-github-bot