Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: EventTarget and Event are available to user code since v15.0.0 #37059

Closed
wants to merge 1 commit into from
Closed

doc: EventTarget and Event are available to user code since v15.0.0 #37059

wants to merge 1 commit into from

Conversation

ExE-Boss
Copy link
Contributor

This should’ve been fixed in #35496.

/cc @addaleax

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Jan 25, 2021
@ExE-Boss ExE-Boss mentioned this pull request Jan 25, 2021
Closed
4 tasks
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2021
@jasnell
Copy link
Member

jasnell commented Jan 25, 2021

There's no reason for this to wait the full minimum time to land. Please 👍🏻 to fast-track

@jasnell
Copy link
Member

jasnell commented Jan 25, 2021

Landed in cd1e73a

@jasnell jasnell closed this Jan 25, 2021
jasnell pushed a commit that referenced this pull request Jan 25, 2021
@ExE-Boss @jasnell
doc: EventTarget and Event are available to user code since v15.0.0
cd1e73a 
PR-URL: #37059
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ExE-Boss ExE-Boss deleted the doc/api/events/event-target/fix-user-code-note branch January 27, 2021 18:14
targos pushed a commit that referenced this pull request Feb 2, 2021
@ExE-Boss @targos
doc: EventTarget and Event are available to user code since v15.0.0
a7b6464 
PR-URL: #37059
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ExE-Boss @jasnell @addaleax @benjamingr @cjihrig @aduh95 @ZYSzys @RaisinTen @targos @nodejs-github-bot