-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix warning in string_search.h #37146
src: fix warning in string_search.h #37146
Conversation
The change looks OK, but I opened the issue because I'm not sure it's enough to just fix the warning. |
@targos I realise that the code here matches this: |
We cannot use that code from V8 as it is not part of their public API. |
In that case should we prefer using the types that were used originally? |
V8 implements this for strings. Strings in JS have a bounded size, which is smaller than |
Landed in c148c3a |
Fixes: #37145