Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: remove webcrypto "DSA" JWK Key Type operations #37203

Closed
wants to merge 3 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Feb 3, 2021

This removes the subtle.exportKey and subtle.importKey option to import/export DSA keys using the 'jwk' format. "DSA" is not a registered JWK key type and is therefore entirely proprietary.

I think we should remove this affordance while the module is still marked as experimental. Alternatively, we could make the kty (Key Type) value a collision-resistant one, e.g. node.DSA.

Either way a breaking change to an experimental module.

The "kty" (key type) parameter identifies the cryptographic algorithm
family used with the key, such as "RSA" or "EC". "kty" values should
either be registered in the IANA "JSON Web Key Types" registry
established by JWA or be a value that contains a Collision-
Resistant Name. The "kty" value is a case-sensitive string.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 3, 2021
@panva panva added the crypto Issues and PRs related to the crypto subsystem. label Feb 3, 2021
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 3, 2021
@nodejs-github-bot
Copy link
Collaborator

@panva
Copy link
Member Author

panva commented Feb 3, 2021

cc @nodejs/crypto

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

panva added a commit that referenced this pull request Feb 5, 2021
"DSA" is not a registered JWK key type.

https://www.iana.org/assignments/jose/jose.xhtml#web-key-types

PR-URL: #37203
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva
Copy link
Member Author

panva commented Feb 5, 2021

Landed in 2ff1c83

@panva panva closed this Feb 5, 2021
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
"DSA" is not a registered JWK key type.

https://www.iana.org/assignments/jose/jose.xhtml#web-key-types

PR-URL: #37203
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Feb 16, 2021
@panva panva deleted the remove-dsa-jwk branch October 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants