Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add romankl to collaborators #3725

Closed
wants to merge 1 commit into from
Closed

doc: add romankl to collaborators #3725

wants to merge 1 commit into from

Conversation

r-52
Copy link
Contributor

@r-52 r-52 commented Nov 9, 2015

No description provided.

@MylesBorins
Copy link
Contributor

LGTM

3 similar comments
@evanlucas
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor

LGTM

@Trott
Copy link
Member

Trott commented Nov 9, 2015

LGTM

@Fishrock123
Copy link
Contributor

Aside:

@romankl you should probably add yourself to the [mailmap] so that your old git info of Roman Klauke <romankl@users.noreply.github.com> maps to your new email.

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Nov 9, 2015
@saghul
Copy link
Member

saghul commented Nov 9, 2015

LGTM

@Fishrock123 Fishrock123 mentioned this pull request Nov 9, 2015
Closed
@jbergstroem
Copy link
Member

🎉 !

@thefourtheye
Copy link
Contributor

This one-liner has a conflict 😮

@r-52
Copy link
Contributor Author

r-52 commented Nov 10, 2015

@Fishrock123 should I include the update in this pr or wait till the next "update AUTHORs" pr ?

@jbergstroem
Copy link
Member

@romankl rebase this branch onto latest master and force push the commit to this branch (to make sure).

@Fishrock123
Copy link
Contributor

@romankl no that can be done in a separate commit. :)

r-52 added a commit that referenced this pull request Nov 10, 2015
@r-52
doc: add romankl to collaborators
5235143 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@r-52
Copy link
Contributor Author

r-52 commented Nov 10, 2015

Thank you!! Landed in 5235143

@r-52 r-52 closed this Nov 10, 2015
@r-52 r-52 deleted the add-to-collab branch November 10, 2015 18:52
r-52 added a commit that referenced this pull request Nov 11, 2015
@r-52 @Fishrock123
doc: add romankl to collaborators
a32d9e3 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
Merged
r-52 added a commit that referenced this pull request Nov 17, 2015
@r-52
doc: add romankl to collaborators
a49dd89 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins
Copy link
Contributor

landed in v4.x-staging in a49dd89

@rvagg rvagg mentioned this pull request Nov 17, 2015
Closed
r-52 added a commit that referenced this pull request Dec 4, 2015
@r-52 @rvagg
doc: add romankl to collaborators
a926659 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
r-52 added a commit that referenced this pull request Dec 17, 2015
@r-52 @jasnell
doc: add romankl to collaborators