crypto: fix subtle.importKey JWK OKP public key import #37255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
crypto
panva
force-pushed
the
webcrypto-fix-okp
branch
from
8eb46ef to
3a2a0ef
Compare
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Feb 6, 2021
panva
added
the
author ready
|
For people like me who need a reference to understand this change: RFC 8037 section 2 |
This comment has been minimized.
This comment has been minimized.
|
cc @nodejs/crypto this is a straight forward fix to an experimental module. |
tniessen
approved these changes
Feb 9, 2021
|
Landed in 51249a1 |
panva
added a commit
that referenced
this pull request
Feb 9, 2021
PR-URL: #37255 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37255 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the subtle.importKey
'jwk'format import of OKP public keys.