Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: bump remark-present-lint-node from 2.0.0 to 2.0.1 #37270

Merged
merged 1 commit into from
Feb 8, 2021
Merged

tools: bump remark-present-lint-node from 2.0.0 to 2.0.1 #37270

merged 1 commit into from
Feb 8, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 8, 2021

This is a prerequisite for #37259.

Please 👍 to fast-track to unblock #37259.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 8, 2021
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 8, 2021
@Trott
Copy link
Member Author

Trott commented Feb 8, 2021

This change is a lint-tool-only change so I think GitHub CI is sufficient (since it runs the linter). If someone disagrees and thinks Jenkins CI is required too, please say something. Thanks.

@Trott
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
72f9c53 
This is a prerequisite for nodejs#37259.

PR-URL: nodejs#37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@Trott
Copy link
Member Author

Trott commented Feb 8, 2021

Landed in 72f9c53"

@Trott Trott merged commit 72f9c53 into nodejs:master Feb 8, 2021
@Trott Trott deleted the lint-preset-2.0.1 branch February 8, 2021 12:27
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@Trott @danielleadams
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
d8d851a 
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This was referenced Feb 16, 2021
Closed
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
5afaeaf 
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@Trott @danielleadams
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
f15b11f 
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @richardlau @BethGriggs @aduh95 @nodejs-github-bot