Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fixed typos in doc/api/deprecations.md and doc/api/diagnostics_channel.md #37282

Merged
merged 1 commit into from
Feb 13, 2021
Merged

doc: fixed typos in doc/api/deprecations.md and doc/api/diagnostics_channel.md #37282

merged 1 commit into from
Feb 13, 2021

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Feb 8, 2021

in doc/api/deprecations.md -> 'ambiguity' was spelled 'ambigiuty'
in doc/api/diagnostics_channel.md -> 'sensitive' was spelled 'senstive' (twice)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 8, 2021
@Trott
Copy link
Member

Trott commented Feb 8, 2021

It's a small thing, and you don't have to worry about it here because it can be fixed (or not) on landing, but our commit messages should use an imperative verb, so "doc: fix typo in foo.md" rather than "doc: fixed typo in foo.md". Normally, I wouldn't say anything, but because it looks like there may be a lot of these, I thought I'd mention it.

Thanks for the PRs!

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marsonya
Copy link
Member Author

marsonya commented Feb 9, 2021

It's a small thing, and you don't have to worry about it here because it can be fixed (or not) on landing, but our commit messages should use an imperative verb, so "doc: fix typo in foo.md" rather than "doc: fixed typo in foo.md". Normally, I wouldn't say anything, but because it looks like there may be a lot of these, I thought I'd mention it.

Thanks for the PRs!

Thank you for bringing it up. I will keep it in mind.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2021
PR-URL: #37282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@aduh95 aduh95 merged commit ce4798b into nodejs:master Feb 13, 2021
@aduh95
Copy link
Contributor

aduh95 commented Feb 13, 2021

Landed in ce4798b

a498aa6 didn't land as the typo was already fixed in f2c2615

danielleadams pushed a commit that referenced this pull request Feb 16, 2021
PR-URL: #37282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
This was referenced Feb 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants