fs: fix pre-aborted writeFile AbortSignal file leak #37393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
|
Could you add a test? Also, do you know if it also happens on |
Sure
It doesn't, however I could add the "optimization" that I added here (the file still opens, even if the signal is already aborted). |
|
(Please add a test) |
1 task
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
2 times, most recently
from
6e0162c
to
dd95fb7
Compare
|
@aduh95 @benjamingr I've added tests. I'm not 100% happy about them, as it's hard for me to know if they'll work consistently on other platforms... However, on my machine they do work consistently on this branch, and fail consistently on master. I'd be happy to improve them if you have any pointers (The tests are essentially copy/pasted from my other fs PR, just changed for the promisified version). EDIT: clearly doesn't work... I'll try to find another solution. |
RaisinTen
reviewed
Feb 19, 2021
RaisinTen
reviewed
Feb 19, 2021
RaisinTen
reviewed
Feb 19, 2021
aduh95
reviewed
Feb 19, 2021
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
from
dd95fb7
to
9778ea3
Compare
|
removed test changes |
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
from
9778ea3
to
758d27a
Compare
benjamingr
approved these changes
Feb 20, 2021
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
from
758d27a
to
edd2871
Compare
aduh95
reviewed
Feb 20, 2021
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
2 times, most recently
from
f828fa8
to
76892da
Compare
aduh95
reviewed
Feb 20, 2021
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
from
76892da
to
936160f
Compare
aduh95
approved these changes
Feb 20, 2021
aduh95
added
the
author ready
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
2 times, most recently
from
f14faab
to
a95971f
Compare
marsonya
approved these changes
Feb 23, 2021
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
from
a95971f
to
6425b00
Compare
Linkgoron
force-pushed
the
fs-write-file-abort-signal-leak
branch
from
6425b00
to
39e50ac
Compare
aduh95
approved these changes
Feb 26, 2021
Fix an issue in writeFile where a file is opened, and not closed if the abort signal is aborted after the file was opened but before writing began. PR-URL: nodejs#37393 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
fs-write-file-abort-signal-leak
branch
from
39e50ac
to
c4180b7
Compare
|
Landed in c4180b7 |
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
Fix an issue in writeFile where a file is opened, and not closed if the abort signal is aborted after the file was opened but before writing began. PR-URL: #37393 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 24, 2021
Fix an issue in writeFile where a file is opened, and not closed if the abort signal is aborted after the file was opened but before writing began. PR-URL: nodejs#37393 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 26, 2021
Fix an issue in writeFile where a file is opened, and not closed if the abort signal is aborted after the file was opened but before writing began. PR-URL: nodejs#37393 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
Fix an issue in writeFile where a file is opened, and not closed if the abort signal is aborted after the file was opened but before writing began. PR-URL: nodejs#37393 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2021
Fix an issue in writeFile where a file is opened, and not closed if the abort signal is aborted after the file was opened but before writing began. PR-URL: #37393 Backport-PR-URL: #38386 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
added
backported-to-v14.x
and removed
author ready
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in
promises.writeFilewhere a file is opened, and not closed if the abort signal is aborted before/during the file was opened.A minor thing is that
fd.closecan still throw, I'm not sure if it's an issue or not.In addition I also added validation for the AbortSignal, and a check where if the signal was already aborted, the file won't be opened at all.
make -j4 test(UNIX), orvcbuild test(Windows) passes