Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.9.0 proposal #37406

Merged
merged 108 commits into from
Feb 18, 2021
Merged

v15.9.0 proposal #37406

merged 108 commits into from
Feb 18, 2021

Commits on Feb 15, 2021

  1. Revert "stream: fix .end() error propagation"

    This reverts commit 4c819d6.
    
    PR-URL: #37060
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
    mcollina authored and danielleadams committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    d2a487e View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. doc: improve promise terminology

    PR-URL: #37181
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    benjamingr authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    67c9a8e View commit details
    Browse the repository at this point in the history
  2. src: read exactly two tokens from Linux THP sysfs config

    There was an unexpected and hard-to-spot issue here:
    the /sys/kernel/mm/transparent_hugepage/enabled file contains three
    entries, and the std::ifstream reader was reading two values on each
    loop iteration, resulting in incorrect behaviour.
    
    Fixes: #37064
    
    PR-URL: #37065
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jayaddison authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    9946c11 View commit details
    Browse the repository at this point in the history
  3. test: split heap snapshot limit tests

    test/parallel/test-heapsnapshot-near-heap-limit.js is timing out in CI
    on low-memory and slow-CPU devices. Split off the worker test to its own
    test file to allow the test to finish in time.
    
    Refs: #36961
    PR-URL: #37189
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    13fe17c View commit details
    Browse the repository at this point in the history
  4. tls: add ability to get cert/peer cert as X509Certificate object

    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #37070
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    jasnell authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    dc84c18 View commit details
    Browse the repository at this point in the history
  5. crypto: add keyObject.export() 'jwk' format option

    Adds [JWK](https://tools.ietf.org/html/rfc7517) keyObject.export format
    option.
    
    Supported key types: `ec`, `rsa`, `ed25519`, `ed448`, `x25519`, `x448`,
    and symmetric keys, resulting in JWK `kty` (Key Type) values `EC`,
    `RSA`, `OKP`, and `oct`.
    
    `rsa-pss` is not supported since the JWK format does not support
    PSS Parameters.
    
    `EC` JWK curves supported are `P-256`, `secp256k1`, `P-384`, and `P-521`
    
    PR-URL: #37081
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    011910b View commit details
    Browse the repository at this point in the history
  6. deps: upgrade npm to 7.5.2

    PR-URL: #37191
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    ruyadorno authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e63b380 View commit details
    Browse the repository at this point in the history
  7. stream: improve Readable.from error handling

    PR-URL: #37158
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    benjamingr authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    1fea051 View commit details
    Browse the repository at this point in the history
  8. doc: fix 404 links in module.md

    PR-URL: #37202
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    ff02e5e View commit details
    Browse the repository at this point in the history
  9. doc: fix pr-url for DEP0148

    PR-URL: #37205
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3f815d9 View commit details
    Browse the repository at this point in the history
  10. tools: update ESLint to 7.19.0

    Update ESLint to 7.19.0
    
    PR-URL: #37159
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    745aad7 View commit details
    Browse the repository at this point in the history
  11. src: simplify calls to BN_bin2bn in prime gen

    PR-URL: #37169
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    bfe0b46 View commit details
    Browse the repository at this point in the history
  12. timers: introduce setInterval async iterator

    Added setInterval async generator to timers\promises.
    Utilises async generators to provide an iterator compatible with
    `for await`.
    
    Co-Authored-By: Fabian Cook <hello@fabiancook.dev>
    
    fix message
    
    PR-URL: #37153
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Linkgoron authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    4ebe38b View commit details
    Browse the repository at this point in the history
  13. test: remove flaky designation for test-http2-large-file

    This seems to have stopped happening, possibly because it only ever
    happened on win2008 and that went eol last year.
    
    Closes: #22327
    
    PR-URL: #37156
    Fixes: #22327
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    5157525 View commit details
    Browse the repository at this point in the history
  14. doc: fix typo in cli.md

    PR-URL: #37214
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    0xkalvin authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    b87c0d6 View commit details
    Browse the repository at this point in the history
  15. http: fix ClientRequest unhandled errors

    ClientRequest could someone cause an unhandled error
    from socket.
    
    Fixes: #36931
    
    PR-URL: #36970
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    ronag authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    4cdc5ea View commit details
    Browse the repository at this point in the history
  16. src: fix warning in string_search.h

    Fixes: #37145
    
    PR-URL: #37146
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    RaisinTen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    48ce1eb View commit details
    Browse the repository at this point in the history
  17. doc: fix typo in globals.md

    PR-URL: #37228
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    eb08afd View commit details
    Browse the repository at this point in the history
  18. timers: remove flaky setInterval test

    PR-URL: #37227
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Nitzan Uziely authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    eb7ec1b View commit details
    Browse the repository at this point in the history
  19. repl: refactor to avoid unsafe array iteration

    PR-URL: #37188
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c377834 View commit details
    Browse the repository at this point in the history
  20. doc: fix CHANGELOG_ARCHIVE table of contents

    PR-URL: #37232
    Refs: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_ARCHIVE.md#0.8.0
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    52c40c7 View commit details
    Browse the repository at this point in the history
  21. doc: fix version number for DEP006

    PR-URL: #37231
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    5906e85 View commit details
    Browse the repository at this point in the history
  22. fs: add AbortSignal support to watch

    PR-URL: #37190
    Refs: #37179
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    benjamingr authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    acd087d View commit details
    Browse the repository at this point in the history
  23. src: refactor bookkeeping of bootstrap status

    This patch
    
    1. Refactors the bootstrap routine of the main instance so that
      when --no-node-snapshot is used,
      Environment::InitializeMainContext() will only be called once
      (previously it would be called twice, which was harmless for now
      but not ideal).
    2. Mark the number of BaseObjects in RunBootstrapping() when creating
      the Environment from scratch and in InitializeMainContext() when
      the Environment is deserialized. Previously the marking was done in
      the Environment constructor and InitializeMainContext() respectively
      for the cctest which was incorrect because the cctest never uses
      an Environment that's not bootstrapped. Also renames the mark
      to base_object_created_after_bootstrap to reflect what it's
      intended for.
    
    PR-URL: #37113
    Refs: #36943
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    2a5f67b View commit details
    Browse the repository at this point in the history
  24. src: put (de)serialization code into node_snapshotable.h/cc

    So that it's easier to find the corresponding code.
    
    PR-URL: #37114
    Refs: #36943
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    joyeecheung authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    337b4e7 View commit details
    Browse the repository at this point in the history
  25. doc: fix accommodate typos

    PR-URL: #37229
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    cjihrig authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    8a25405 View commit details
    Browse the repository at this point in the history
  26. vm: add importModuleDynamically option to compileFunction

    This reverts commit 2d5d773.
    
    See: #32985
    See: #33364
    See: #33166
    Fixes: #31860
    
    PR-URL: #35431
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    devsnek authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    66a14d3 View commit details
    Browse the repository at this point in the history
  27. fs: use a default callback for fs.close()

    The `fs.close()` function requires a callback. Most often the only thing
    that callback does is check and rethrow the error if one occurs. To
    eliminate common boilerplate, make the callback optional with a default
    that checks and rethrows the error as an uncaught exception.
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #37174
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jasnell authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    655d196 View commit details
    Browse the repository at this point in the history
  28. doc: fix webcrypto HMAC generateKey example

    PR-URL: #37197
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    0702d60 View commit details
    Browse the repository at this point in the history
  29. doc: mention CryptoKey in port.postMessage()

    PR-URL: #37196
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    596bfb3 View commit details
    Browse the repository at this point in the history
  30. doc: consistent webcrypto node.keyObject format

    PR-URL: #37200
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    panva authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    aebe532 View commit details
    Browse the repository at this point in the history
  31. doc: mark Certificate methods as static, add missing KeyObject.from

    PR-URL: #37198
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    760f126 View commit details
    Browse the repository at this point in the history
  32. crypto: remove webcrypto "DSA" JWK Key Type operations

    "DSA" is not a registered JWK key type.
    
    https://www.iana.org/assignments/jose/jose.xhtml#web-key-types
    
    PR-URL: #37203
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3e2746f View commit details
    Browse the repository at this point in the history
  33. test: rename n-api to node-api

    This renames the macros used in the tests from `NAPI_*` to
    `NODE_API_*`.
    
    PR-URL: #37217
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Gabriel Schulhof authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    48a634e View commit details
    Browse the repository at this point in the history
  34. fs: allow passing negative zero fd

    Fixes: #37122
    
    PR-URL: #37123
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RaisinTen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c302450 View commit details
    Browse the repository at this point in the history
  35. repl: add auto‑completion for dynamic import calls

    Refs: #33238
    Refs: #33282
    
    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    
    PR-URL: #37178
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ExE-Boss authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3fee5b2 View commit details
    Browse the repository at this point in the history
  36. timers: fix unsafe array iteration

    Fixes: #37222
    
    PR-URL: #37223
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RaisinTen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    dc38dd2 View commit details
    Browse the repository at this point in the history
  37. crypto: fix and simplify prime option validation

    PR-URL: #37164
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    9dac99a View commit details
    Browse the repository at this point in the history
  38. lib: add weak event handlers

    PR-URL: #36607
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    benjamingr authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    acabe08 View commit details
    Browse the repository at this point in the history
  39. src: use make_shared for safe allocation

    Using the reset does a double allocation and is error prone if some
    exception occured which is very unlikely but can happen. make_shared_ptr
    gives hedge over this and handle the failure in allocation.
    
    PR-URL: #37139
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    yashLadha authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    354df9e View commit details
    Browse the repository at this point in the history
  40. src: add context for TODO comment in env.cc

    Add more context around the TODO change required for achieving the
    task. When destructuring the isolate and environment_vars from the
    environment object, it is leading to recursive dependency and thus not
    able to refactor it in a better way.
    
    PR-URL: #37140
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    yashLadha authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    a6053dc View commit details
    Browse the repository at this point in the history
  41. deps: V8: backport dfcf1e86fac0

    Original commit message:
    
        [wasm] PostMessage of Memory.buffer should throw
    
        PostMessage of an ArrayBuffer that is not detachable should result
        in a DataCloneError.
    
        Bug: chromium:1170176, chromium:961059
        Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
        Reviewed-by: Adam Klein <adamk@chromium.org>
        Reviewed-by: Andreas Haas <ahaas@chromium.org>
        Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#72415}
    
    Refs: v8/v8@dfcf1e8
    
    PR-URL: #37245
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    20c65b0 View commit details
    Browse the repository at this point in the history
  42. tools: fix d8 macOS build

    libv8_base doesn't exist anymore.
    
    PR-URL: #37211
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    eb0daae View commit details
    Browse the repository at this point in the history
  43. src: avoid implicit type conversions

    This fixes a bunch of C4244 ('conversion' conversion from 'type1' to
    'type2', possible loss of data) MSVC warnings in the code base.
    
    PR-URL: #37149
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3079a78 View commit details
    Browse the repository at this point in the history
  44. src: rename binding_data_name to type_name in BindingData

    Previously, this was a per-class string constant for BindingData
    which is used as keys for identifying these objects in the binding
    data map. These are just type names of the BindingData.
    This patch renames the variable to type_name so that
    we can generalize this constant for other BaseObjects and use
    it for debugging and logging the types of other BaseObjects.
    
    PR-URL: #37112
    Refs: #36943
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    joyeecheung authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    54d36b0 View commit details
    Browse the repository at this point in the history
  45. src: refactor v8 binding

    1. Put the v8 binding data class into a header so we can reuse
      the class definition during deserialization.
    2. Put the v8 binding code into node::v8_utils namespace for
      clarity.
    3. Move the binding data property initialization into its
      constructor so that we can reuse it during deserialization
    4. Reorder the v8 binding initialization so that we don't
      unnecessarily initialize the properties in a loop
    
    PR-URL: #37112
    Refs: #36943
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    joyeecheung authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    1a9bcdf View commit details
    Browse the repository at this point in the history
  46. tools: bump remark-present-lint-node from 2.0.0 to 2.0.1

    This is a prerequisite for #37259.
    
    PR-URL: #37270
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d8d851a View commit details
    Browse the repository at this point in the history
  47. doc: rename N-API to Node-API

    Refs: nodejs/abi-stable-node#420
    PR-URL: #37259
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Gabriel Schulhof authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    ebf3597 View commit details
    Browse the repository at this point in the history
  48. util: use assert for unreachable code

    Great effort is taken to keep `util.inspect()` from throwing while
    inspecting a linked list or other items that require recursion. It is
    likely still possible at this time to cause a throw with prototype
    pollution, but that will change soon when the code is modified to use
    primordials.
    
    This commit instructs our coverage to not be concerned about not being
    able to reach the throwing-an-error code and changes the throw there to
    an assert so users will be instructed to open a bug with Node.js should
    they manage to cause the code to throw.
    
    PR-URL: #37249
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    7c51cec View commit details
    Browse the repository at this point in the history
  49. doc: use sentence case for headers in BUILDING.md

    Be consistent with the rest of the file and our doc style guide.
    
    PR-URL: #37250
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    7da1c9b View commit details
    Browse the repository at this point in the history
  50. doc: use sentence case in README headers

    Comply with our docs and our style guide.
    
    PR-URL: #37251
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    47c4f1f View commit details
    Browse the repository at this point in the history
  51. doc: fix typo in console.md

    PR-URL: #37279
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    marsonya authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    0e887ca View commit details
    Browse the repository at this point in the history
  52. doc: fix typo in crypto.md

    PR-URL: #37279
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    marsonya authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    5a4288e View commit details
    Browse the repository at this point in the history
  53. doc: warn about using strings as inputs in crypto

    PR-URL: #37248
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    cd50e93 View commit details
    Browse the repository at this point in the history
  54. module: use optional chaining in cjs/loader.js

    PR-URL: #37238
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RaisinTen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    a693baa View commit details
    Browse the repository at this point in the history
  55. crypto: avoid infinite loops in prime generation

    PR-URL: #37212
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    55fd6b6 View commit details
    Browse the repository at this point in the history
  56. test: only run prime test with supported OpenSSL

    PR-URL: #37212
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    8483de4 View commit details
    Browse the repository at this point in the history
  57. lib: fix WebIDL object and dictionary type conversion

    PR-URL: #37047
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ExE-Boss authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    f6f9af6 View commit details
    Browse the repository at this point in the history
  58. tools: add GitHub Action linter for pr-url

    PR-URL: #37221
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    6db5e79 View commit details
    Browse the repository at this point in the history
  59. deps: upgrade npm to 7.5.3

    PR-URL: #37283
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ruyadorno authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d1c1724 View commit details
    Browse the repository at this point in the history
  60. doc: fix misnamed SHASUMS256.txt name in README.md

    PR-URL: #37260
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    marsonya authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    85bed2e View commit details
    Browse the repository at this point in the history
  61. crypto: fix subtle.importKey JWK OKP public key import

    PR-URL: #37255
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e28ea89 View commit details
    Browse the repository at this point in the history
  62. src: add mutex to ManagedEVPPKey class

    This commit introduces a mutex field on the ManagedEVPPKey class
    intended to be used when multiple threads require access to an OpenSSL
    EVP_PKEY object. The motivation for this came from the work being done
    to upgrade Node.js to OpenSSL 3.0.
    
    OpenSSL objects, like EVP_PKEY, are not thread safe (see refs for
    details). In versions prior to OpenSSL 3.0 this was not noticeable and
    did not cause any issues (like incorrect logic or crashes), but with
    OpenSSL 3.0 this does cause issues if access to an EVP_PKEY instance is
    required from multiple threads without locking.
    
    In OpenSSL 3.0 when the evp_pkey_downgrade function is called, which
    downgrades an EVP_PKEY instance to a legacy version, it will clear all
    the fields of EVP_PKEY struct except the lock (#13374). But this also
    means that keymgmt and keydata will also be cleared, which other parts
    of the code base depends on, and those calls will either fail to export
    the key (returning null) or crash due to a segment fault.
    
    This same code works with OpenSSL 1.1.1 without locking and I think this
    is because there is no downgrade being done in OpenSSL 1.1.1. But even
    so, as far as I can tell there are no guarantees that these object are
    thread safe in 1.1.1 either and should be protected with a lock.
    
    PR-URL: #36825
    Refs: openssl/openssl#13374
    Refs: openssl/openssl#13374
    Refs: openssl/openssl#2165)
    Refs: https://www.openssl.org/blog/blog/2017/02/21/threads
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    42cc33c View commit details
    Browse the repository at this point in the history
  63. node-api: allow retrieval of add-on file name

    Unlike JS-only modules, native add-ons are always associated with a
    dynamic shared object from which they are loaded. Being able to
    retrieve its absolute path is important to native-only add-ons, i.e.
    add-ons that are not themselves being loaded from a JS-only module
    located in the same package as the native add-on itself.
    
    Currently, the file name is obtained at environment construction time
    from the JS `module.filename`. Nevertheless, the presence of `module`
    is not required, because the file name could also be passed in via a
    private property added onto `exports` from the `process.dlopen`
    binding.
    
    As an attempt at future-proofing, the file name is provided as a URL,
    i.e. prefixed with the `file://` protocol.
    
    Fixes: nodejs/node-addon-api#449
    PR-URL: #37195
    Co-authored-by: Michael Dawson <mdawson@devrus.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    2 people authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    061939d View commit details
    Browse the repository at this point in the history
  64. http: explain the unused argument in IncomingMessage._read

    PR-URL: #37275
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Ayase-252 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d63ac28 View commit details
    Browse the repository at this point in the history
  65. http: explain the possibilty of refactor unused argument

    PR-URL: #37275
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Ayase-252 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    f5d1bf9 View commit details
    Browse the repository at this point in the history
  66. src: fix return type of method in string_search.h

    `Vector::forward()` is supposed to return a `bool`.
    
    PR-URL: #37167
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RaisinTen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e28fa6c View commit details
    Browse the repository at this point in the history
  67. doc: discourage error event

    PR-URL: #37264
    Refs: #37237
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    benjamingr authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3464c9f View commit details
    Browse the repository at this point in the history
  68. deps: V8: cherry-pick 0c8b6e415c30

    Original commit message:
    
        [mac][wasm] Work around MacOS 11.2 code page decommit failures
    
        MacOS 11.2 refuses to set "no access" permissions on memory that
        we previously used for JIT-compiled code. It is still unclear
        whether this is WAI on the part of the kernel. In the meantime,
        as a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead
        of mprotect(..., NONE) when discarding code pages. This is inspired
        by what Chromium's gin platform does.
    
        Fixed: v8:11389
        Change-Id: I866586932573b4253002436ae5eee4e0411c45fc
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688
        Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
        Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
        Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#72559}
    
    Refs: v8/v8@0c8b6e4
    Fixes: #37061
    PR-URL: #37276
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    matinzd authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    50e81ba View commit details
    Browse the repository at this point in the history
  69. doc: fix description of hasSubscribers

    PR-URL: #37324
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    facf3a5 View commit details
    Browse the repository at this point in the history
  70. doc: refactor fs docs structure

    * Convert examples to esm to help promote that pattern with users
    * Make Promises APIs more prominent to help promite that pattern
    * Separate callback/sync apis into distinct sections to make those
      more consistent with the Promises api
    * Improve other bits and pieces
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #37170
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    jasnell authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    7d8fd3f View commit details
    Browse the repository at this point in the history
  71. module: make synthetic module evaluation steps return a Promise to su…

    …pport top level await
    
    Top level await expects that all module script evaluation returns a
    Promise. As such, update
    ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a
    resolved Promise now that V8 has enabled top-level await by default.
    
    Unfortunately I don't have a spec reference that I can point to here
    because the Built-in modules proposal isn't yet updated for
    top level await.
    
    The corresponding change for Blink is
    https://chromium-review.googlesource.com/c/chromium/src/+/2568823.
    
    This will allow a workaround for Node in this V8 bugfix to be removed:
    https://chromium-review.googlesource.com/c/v8/v8/+/2673794.
    
    Fixes: #37299
    
    PR-URL: #37300
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    dandclark authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d96a97a View commit details
    Browse the repository at this point in the history
  72. tools: avoid pending deprecation in doc generator

    `unist-util-find` depends on `lodash.iteratee` which uses
    `process.binding()`.
    Let's remove this dependency which is used in one place to do a very
    simple thing.
    
    PR-URL: #37267
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    targos authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    1ff375b View commit details
    Browse the repository at this point in the history
  73. child_process: fix bad abort signal leak

    Move abort signal validation to before spawn is executed
    so that the file is not leaked.
    
    PR-URL: #37257
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Nitzan Uziely authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    8487184 View commit details
    Browse the repository at this point in the history
  74. errors: align source-map stacks with spec

    Reformat stack traces when --enable-source-maps flag is set to format
    more likely to fit https://github.com/tc39/proposal-error-stacks
    
    PR-URL: #37252
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    bcoe authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    15804e0 View commit details
    Browse the repository at this point in the history
  75. test: re-implement promises.setInterval() test robustly

    Fixes: #37226
    
    PR-URL: #37230
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    1fc8307 View commit details
    Browse the repository at this point in the history
  76. async_hooks: set unhandledRejection async context

    This commit now executes `process.on('unhandledRejection')` in the
    async execution context of the concerned `Promise`.
    
    PR-URL: #37281
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Sajal Khandelwal authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d0f1ff5 View commit details
    Browse the repository at this point in the history
  77. url: move URLSearchParams method definitions

    PR-URL: #36799
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    ExE-Boss authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    fbcab10 View commit details
    Browse the repository at this point in the history
  78. url: fix definitions of URL/SearchParams methods and accessors

    This fixes getter and setter names for the WHATWG URL classes, and fixes
    a few other inconsistencies with browsers implementations.
    
    Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
    
    PR-URL: #36799
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    ExE-Boss authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    676f696 View commit details
    Browse the repository at this point in the history
  79. tools: fix lint-pr-url message

    PR-URL: #37304
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    a483c28 View commit details
    Browse the repository at this point in the history
  80. doc: fix typo in /api/dns.md

    PR-URL: #37312
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    marsonya authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    cdd2fe5 View commit details
    Browse the repository at this point in the history
  81. doc: add version metadata for packages features

    PR-URL: #37289
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    804e7ae View commit details
    Browse the repository at this point in the history
  82. doc: fix typo in buffer.md

    PR-URL: #37268
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    marsonya authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    f253cb9 View commit details
    Browse the repository at this point in the history
  83. doc: fix typo in deprecations.md

    PR-URL: #37282
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    marsonya authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    85b1476 View commit details
    Browse the repository at this point in the history
  84. perf_hooks: introduce createHistogram

    Adds a new `perf_hooks.createHistogram()` API for creating histogram
    instances that allow user recording.
    
    Makes Histogram instances cloneable via MessagePort. This allows, for
    instance, an event loop delay monitor to be running on the main thread
    while the histogram data can be monitored actively from a worker thread.
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #37155
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    jasnell authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c4faa39 View commit details
    Browse the repository at this point in the history
  85. doc: fix performanceEntry.flags style format

    PR-URL: #37274
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    chengcyber authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    610b29b View commit details
    Browse the repository at this point in the history
  86. doc: apply sentence case to release doc headers

    Our style is to use sentence case for headers and documentation titles.
    The documentation for releases uses both sentence case and title case.
    This change applies sentence case consistently throughout.
    
    PR-URL: #37349
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    189ce39 View commit details
    Browse the repository at this point in the history
  87. doc: apply sentence-consistently in C++ style guide

    Use sentence case for headers consistently. This makes the document
    internally consistent and also aligns it with our docs generally and the
    style guide we use for docs.
    
    PR-URL: #37350
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    62b2648 View commit details
    Browse the repository at this point in the history
  88. doc: use sentence case in benchmark doc

    Apply sentence case consistently in headers in benchmark doc.
    
    PR-URL: #37351
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    392c86d View commit details
    Browse the repository at this point in the history
  89. doc: alphabetize crypto.* methods

    The list of methods on the `crypto` object is almost in alphabetical
    order but not quite. This change alphabetizes the methods.
    
    PR-URL: #37353
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    1e99175 View commit details
    Browse the repository at this point in the history
  90. meta: update README releases section

    PR-URL: #37318
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Zuzana Svetlikova authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3db1b30 View commit details
    Browse the repository at this point in the history
  91. doc: link PACKAGE_EXPORTS_RESOLVE to ESM section

    Linked PACKAGE_EXPORTS_RESOLVE to "Resolver Algorithm Specification" in
    "ECMAScript modules" page, so that the `require` pseudocode is easier to
    understand.
    
    PR-URL: #37135
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ugultopu authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    e2a2bab View commit details
    Browse the repository at this point in the history
  92. doc: fix backticks in crypto API docs

    PR-URL: #37269
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    f5e4625 View commit details
    Browse the repository at this point in the history
  93. doc: fix quotes in stream docs

    PR-URL: #37269
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c188466 View commit details
    Browse the repository at this point in the history
  94. doc: optimize HTML rendering

    Defer rendering sections of docs until they are displayed on
    the user's screen.
    
    PR-URL: #37301
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    dd054ca View commit details
    Browse the repository at this point in the history
  95. buffer: add @@toStringTag to Blob

    This commit adds the toStringTag to the Blob class to match
    the behavior of Chrome and Firefox.
    
    PR-URL: #37336
    Fixes: #37337
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c160d88 View commit details
    Browse the repository at this point in the history
  96. tools: update ESLint to 7.20.0

    Update ESLint to 7.20.0
    
    PR-URL: #37339
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    b2b6411 View commit details
    Browse the repository at this point in the history
  97. fs: add fsPromises.watch()

    An alternative to `fs.watch()` that returns an `AsyncIterator`
    
    ```js
    const { watch } = require('fs/promises');
    
    (async () => {
    
      const ac = new AbortController();
      const { signal } = ac;
      setTimeout(() => ac.abort(), 10000);
    
      const watcher = watch('file.txt', { signal });
    
      for await (const { eventType, filename } of watcher) {
        console.log(eventType, filename);
      }
    
    })()
    ```
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #37179
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    jasnell authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    88d3f74 View commit details
    Browse the repository at this point in the history
  98. policy: fix cascade getting scope

    PR-URL: #37298
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Co-authored-by: James M Snell <jasnell@gmail.com>
    2 people authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    799b2d5 View commit details
    Browse the repository at this point in the history
  99. repl: refactor to avoid unsafe array iteration

    PR-URL: #37345
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    6d53e79 View commit details
    Browse the repository at this point in the history
  100. worker: refactor to avoid unsafe array iteration

    PR-URL: #37346
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    05a16e7 View commit details
    Browse the repository at this point in the history
  101. deps: upgrade to libuv 1.41.0

    Notable changes:
    
    - The IBM i platform has been promoted to a Tier 2 platform.
    - libuv is now built with `-fno-strict-aliasing`, and recommends
      that projects using libuv do the same.
    - `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid directory
      names on Windows.
    - `uv_uptime()` now returns the correct value on OpenVZ containers.
    - Windows 8 is the new minimum supported version of Windows.
    - Bind errors are now reported from `uv_tcp_connect()`.
    - The `uv_pipe()` function has been added.
    - The `uv_socketpair()` function has been added.
    - `uv_read_start()` error handling has been unified across
      Windows and Unix.
    
    PR-URL: #37360
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    cjihrig authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c0eadef View commit details
    Browse the repository at this point in the history
  102. test: enable no-restricted-syntax rule for test-timers-promisified

    PR-URL: #37357
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    b09d21b View commit details
    Browse the repository at this point in the history
  103. doc: add dmabupt to collaborators

    PR-URL: #37377
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com
    dmabupt authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d808db2 View commit details
    Browse the repository at this point in the history
  104. lib: simplify check in child_process

    PR-URL: #37367
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c6198fd View commit details
    Browse the repository at this point in the history
  105. tools: refactor prefer-primordials

    Use optional chaining to improve code readability and remove use of
    `Array.prototype.reduce`.
    
    PR-URL: #36018
    Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    2e1f1c6 View commit details
    Browse the repository at this point in the history
  106. test: fix test-doctool-html

    Refs: #37301
    
    PR-URL: #37397
    Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    aduh95 authored and danielleadams committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    b5692b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. 2021-02-17, Version 15.9.0 (Current)

    PR-URL: #37406
    
    Notable Changes:
    
    * crypto:
      * add keyObject.export() jwk format option (Filip Skokan) #37081
    * deps:
      * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
    * doc:
      * add dmabupt to collaborators (Xu Meng) #37377
      * refactor fs docs structure (James M Snell) #37170
    * fs:
      * add fsPromises.watch() (James M Snell) #37179
      * use a default callback for fs.close() (James M Snell) #37174
      * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
    * perf_hooks:
      * introduce createHistogram (James M Snell) #37155
    * stream:
      * improve Readable.from error handling (Benjamin Gruenbaum) #37158
    * timers:
      * introduce setInterval async iterator (linkgoron) #37153
    * tls:
      * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
    danielleadams committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    877f66e View commit details
    Browse the repository at this point in the history