-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: refactor hasAnyNotIn to avoid unsafe array iteration #37433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
Issues and PRs related to general changes in the lib or src directory.
label
Feb 18, 2021
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/953/ EDIT: Perf results look OK
|
jasnell
approved these changes
Feb 18, 2021
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 18, 2021
This comment has been minimized.
This comment has been minimized.
aduh95
force-pushed
the
hasAnyNotIn-array-iteration
branch
from
February 19, 2021 12:01
e7283ad
to
230d47d
Compare
This comment has been minimized.
This comment has been minimized.
aduh95
force-pushed
the
hasAnyNotIn-array-iteration
branch
from
February 19, 2021 12:26
230d47d
to
333e133
Compare
This comment has been minimized.
This comment has been minimized.
tniessen
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better than the alternative.
juanarbol
approved these changes
Feb 22, 2021
aduh95
force-pushed
the
hasAnyNotIn-array-iteration
branch
from
February 25, 2021 09:33
333e133
to
a7b4309
Compare
PR-URL: nodejs#37433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
force-pushed
the
hasAnyNotIn-array-iteration
branch
from
February 26, 2021 15:34
a7b4309
to
75259c7
Compare
Landed in 75259c7 |
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
PR-URL: #37433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
lib / src
Issues and PRs related to general changes in the lib or src directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @tniessen in #37364 (comment).