Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document the NO_COLOR and FORCE_COLOR env vars #37477

Closed
wants to merge 1 commit into from
Closed

doc: document the NO_COLOR and FORCE_COLOR env vars #37477

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 22, 2021

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #37404

@jasnell jasnell mentioned this pull request Feb 22, 2021
Closed
Trott
Trott reviewed Feb 22, 2021
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Feb 22, 2021
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Feb 22, 2021
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Feb 22, 2021

These entries need to be duplicated into doc/node.1 so that they show up in the man page.

lpinca
lpinca approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @Trott's nits addressed.

Trott
Trott reviewed Feb 23, 2021
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
Trott
Trott previously requested changes Feb 23, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but leaving a "Request changes" until the entries are in doc/node.1 as well. Feel free to dismiss this review once that's happened.

@jasnell jasnell force-pushed the no_color_force-color branch from e9a759f to 1d4d8b2 Compare February 23, 2021 15:22
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. labels Feb 23, 2021
BridgeAR
BridgeAR reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments.

doc/api/cli.md Outdated Show resolved Hide resolved
doc/api/cli.md Outdated Show resolved Hide resolved
@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2021
@jasnell jasnell force-pushed the no_color_force-color branch from 1d4d8b2 to ff754fe Compare February 25, 2021 22:38
@jasnell
doc: document the NO_COLOR and FORCE_COLOR env vars
95b0fe7 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#37404
@jasnell jasnell force-pushed the no_color_force-color branch from ff754fe to 95b0fe7 Compare February 25, 2021 22:43
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36378/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36380/

@jasnell
Copy link
Member Author

jasnell commented Feb 26, 2021

Landed in fc6d8f4

@jasnell jasnell closed this Feb 26, 2021
jasnell added a commit that referenced this pull request Feb 26, 2021
@jasnell
doc: document the NO_COLOR and FORCE_COLOR env vars
fc6d8f4 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@sthagen sthagen mentioned this pull request Feb 27, 2021
Merged
targos pushed a commit that referenced this pull request Feb 28, 2021
@jasnell @targos
doc: document the NO_COLOR and FORCE_COLOR env vars
3b7cb75 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
Alhadis
Alhadis reviewed Mar 5, 2021
View reviewed changes
doc/node.1
Comment on lines +535 to +536
.Ar 1
,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most mdoc(7) macros allow authors to include trailing punctuation as a separate (final) argument:

.Ar 1 ,

See the "Delimiters" section of mdoc(7) for more info on this feature.

targos pushed a commit that referenced this pull request May 27, 2021
@jasnell @targos
doc: document the NO_COLOR and FORCE_COLOR env vars
7a67a90 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
@jasnell @targos
doc: document the NO_COLOR and FORCE_COLOR env vars
5cf0b58 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell @targos
doc: document the NO_COLOR and FORCE_COLOR env vars
f0daaec 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@jasnell @targos
doc: document the NO_COLOR and FORCE_COLOR env vars
2168e95 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Electroid Electroid mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@Alhadis Alhadis Alhadis left review comments

@juanarbol juanarbol juanarbol approved these changes

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please document FORCE_COLOR/NO_COLOR in node -h output
8 participants
@jasnell @Trott @nodejs-github-bot @lpinca @Alhadis @BridgeAR @aduh95 @juanarbol