Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add link to [customizing util.inspect colors]. #3748

Closed
wants to merge 1 commit into from

Conversation

jmm
Copy link
Contributor

@jmm jmm commented Nov 10, 2015

Previously this said "see below" to nowhere.

I have the same thing for v4.x.

  1. Another option would be to link to the util.inspect() documentation for all of the options (showHidden|depth|colors) instead of duplicating them (that'd be my preference, unless the build system can accomodate that content being located in one place and inserted in both places in the output).

  2. The task for building the docs depends on building Node? That is prohibitively slow for making docs changes. (I'm doing it where I already have a functioning Node installation.) I had to hack the build scripts to get around that to be able to make these changes, and I wouldn't attempt this again without being able to build them using the existing Node install. It's possible I've misunderstood or done something wrong -- I just followed the instructions from the README: $ make doc.

  3. What does CONTRIBUTING.md mean?:

    The rules for the master branch are less strict;

    Less strict than what?

@Trott
Copy link
Member

Trott commented Nov 10, 2015

I think you want to target the pull request against master rather than v5.x.

@mscdex mscdex added doc Issues and PRs related to the documentations. console Issues and PRs related to the console subsystem. labels Nov 10, 2015
@mikeal
Copy link
Contributor

mikeal commented Nov 10, 2015

Everything lands in master and then is cherry-picked into a release branch unless it is for an issues specific to that release line.

@Fishrock123
Copy link
Contributor

@jmm Could you please open a new Pull Request with the merge base / target set to master? Thanks!

@jmm
Copy link
Contributor Author

jmm commented Nov 10, 2015

Thanks @Trott @mikeal @Fishrock123. I actually saw that (it's right above the part that I linked to), but lost track of it obviously. Sorry about that. I pushed the original commit here again so it's not showing 56 participants anymore (I hope those people didn't get spammed as a result of that...ugh).

@Fishrock123 Opened #3749.

@jmm jmm closed this Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants