Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise CI text in collaborator guide #37526

Merged
merged 1 commit into from
Mar 1, 2021
Merged

doc: revise CI text in collaborator guide #37526

merged 1 commit into from
Mar 1, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 26, 2021

Minor clarifications to text. For example, this moves the "(green or
yellow)" parenthetical closer to the text to which it applies. (It
applies only to Jenkins CI.)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 26, 2021
Minor clarifications to text. For example, this moves the "(green or
yellow)" parenthetical closer to the text to which it applies. (It
applies only to Jenkins CI.)

PR-URL: nodejs#37526
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@Trott
Copy link
Member Author

Trott commented Mar 1, 2021

Landed in 67bc0ec

@Trott Trott merged commit 67bc0ec into nodejs:master Mar 1, 2021
@Trott Trott deleted the ci branch March 1, 2021 06:44
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
Minor clarifications to text. For example, this moves the "(green or
yellow)" parenthetical closer to the text to which it applies. (It
applies only to Jenkins CI.)

PR-URL: nodejs#37526
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit that referenced this pull request Mar 2, 2021
Minor clarifications to text. For example, this moves the "(green or
yellow)" parenthetical closer to the text to which it applies. (It
applies only to Jenkins CI.)

PR-URL: #37526
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit that referenced this pull request May 1, 2021
Minor clarifications to text. For example, this moves the "(green or
yellow)" parenthetical closer to the text to which it applies. (It
applies only to Jenkins CI.)

PR-URL: #37526
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants