Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,lib: add missing deprecation code #37541

Merged
merged 1 commit into from
Mar 1, 2021
Merged

doc,lib: add missing deprecation code #37541

merged 1 commit into from
Mar 1, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 27, 2021

Refs: #37136

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 27, 2021
@targos targos added doc Issues and PRs related to the documentations. dont-land-on-v10.x labels Feb 28, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36407/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36414/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2021
@cjihrig
doc,lib: add missing deprecation code
b3f35e2 
PR-URL: nodejs#37541
Refs: nodejs#37136
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit b3f35e2 into nodejs:master Mar 1, 2021
@cjihrig cjihrig deleted the derp branch March 1, 2021 22:42
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
@cjihrig @lpinca
doc,lib: add missing deprecation code
a7dd6fb 
PR-URL: nodejs#37541
Refs: nodejs#37136
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @nodejs-github-bot @jasnell @Trott @addaleax @lpinca @richardlau @aduh95 @marsonya @targos