Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include minimal V8 headers in distribution #37570

Closed
wants to merge 1 commit into from

Commits on Mar 10, 2021

  1. build: include minimal V8 headers in distribution

    Because Node.js currently distributes all V8 headers, it is not clear
    which ones are part of our API and ABI compatibility contract. V8 may
    add, remove, or change headers at any time, preventing us sometimes
    from updating because the change could affect addons which may depend
    on them. Moreover, the `cppgc` library, included in V8, is exposed
    even though it is still in active development and doesn't have a
    stable API.
    Node.js should choose exactly which headers are exposed and part of
    our native API, so that it's easier to reason about changes during V8
    updates and to prevent us from automatically increasing the API
    surface when new headers are added by V8.
    Instead of specifically excluding v8-inspector, only include `v8.h`,
    `v8-platform.h` (used in `node.h`) and `v8-profiler.h`.
    targos committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    a97b42c View commit details
    Browse the repository at this point in the history