Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] errors: do not call resolve on URLs with schemes #37717

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] errors: do not call resolve on URLs with schemes #37717

wants to merge 1 commit into from

Commits on Apr 24, 2021

  1. errors: do not call resolve on URLs with schemes 

    We were incorrectly trying to run path.resolve on absolute
sources URLs. This was breaking webpack:// URLs in stack
trace output.

Refs: nodejs#35325

PR-URL: nodejs#35903
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @bcoe @targos
    bcoe authored and targos committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    753d783 View commit details
    Browse the repository at this point in the history