Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add known_issues test for #13683 #37744

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 13, 2021

Add a known_issues test for a known Windows issue.

Refs: #13683

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 13, 2021
@nodejs-github-bot

This comment has been minimized.

@richardlau
Copy link
Member

You may need to add a section and skip for IBM i.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 13, 2021

@Trott
Copy link
Member Author

Trott commented Mar 14, 2021

According to the docs:

The path.relative() method returns the relative path from from to to based on the current working directory.

So you'll get different results depending on where you are in the file system.

> process.cwd()
'/'
> path.posix.relative('a/b/c', '../../x');
'../../../x'
> process.chdir('/Users/trott/io.js')
undefined
> process.cwd()
'/Users/trott/io.js'
> path.posix.relative('a/b/c', '../../x');
'../../../../../x'
> 

So I updated the test to use a regex to make sure we cover all (three) possibilities.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 14, 2021

Add a known_issues test for a known Windows issue.

Refs: nodejs#13683

PR-URL: nodejs#37744
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@Trott
Copy link
Member Author

Trott commented Mar 18, 2021

Landed in 55f0955

@Trott Trott merged commit 55f0955 into nodejs:master Mar 18, 2021
@Trott Trott deleted the test-for-13683 branch March 18, 2021 04:58
ruyadorno pushed a commit that referenced this pull request Mar 20, 2021
Add a known_issues test for a known Windows issue.

Refs: #13683

PR-URL: #37744
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Add a known_issues test for a known Windows issue.

Refs: #13683

PR-URL: #37744
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants