crypto: use macro map for NodeCryptoError #37758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
approved these changes
Mar 15, 2021
addaleax
approved these changes
Mar 15, 2021
src/crypto/crypto_util.h
Outdated
| } | ||
| errors_.emplace_back(SPrintF(error_string, | ||
| std::forward<Args>(args)...)); | ||
| } | ||
| #undef NODE_CRYPTO_ERROR_CODES_MAP |
There was a problem hiding this comment.
Having this available outside of the header might be useful at some point 🤷♀️
There was a problem hiding this comment.
No, not right now, although I guess if we add more error codes to CryptoErrorStore::Insert() then it might make sense to move the part that generates error_string/that doesn’t use args back into a .cc file (because right now every call to CryptoErrorStore::Insert() potentially creates a new copy of the function).
RaisinTen
added
the
author ready
jasnell
pushed a commit
that referenced
this pull request
Mar 19, 2021
PR-URL: #37758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 971e009 |
ruyadorno
pushed a commit
that referenced
this pull request
Mar 24, 2021
PR-URL: #37758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.