Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix header name #37792

Closed
wants to merge 1 commit into from
Closed

crypto: fix header name #37792

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

cc @nodejs/crypto

File is renamed in #37048. Now is useless.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 18, 2021
@gengjiawen gengjiawen requested review from jasnell and tniessen March 18, 2021 06:50
richardlau
richardlau reviewed Mar 18, 2021
View reviewed changes
node.gyp Show resolved Hide resolved
@gengjiawen gengjiawen changed the title crypto: cleanup unused file crypto: fix header name Mar 18, 2021
@gengjiawen gengjiawen requested a review from richardlau March 18, 2021 11:59
richardlau
richardlau approved these changes Mar 18, 2021
View reviewed changes
node.gyp Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36861/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36872/

@gengjiawen
Copy link
Member Author

Landed in 0ca410c

@gengjiawen gengjiawen closed this Mar 21, 2021
gengjiawen added a commit that referenced this pull request Mar 21, 2021
@gengjiawen
crypto: fix header name
0ca410c 
PR-URL: #37792
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gengjiawen gengjiawen deleted the crypto-fix branch March 21, 2021 03:13
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@gengjiawen @ruyadorno
crypto: fix header name
11d4585 
PR-URL: #37792
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gengjiawen @nodejs-github-bot @jasnell @Trott @lpinca @tniessen @richardlau @RaisinTen @targos