child_process: cleanup AbortSignal code duplication #37823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanup AbortSignal child_process code duplication
nodejs-github-bot
added
child_process
Linkgoron
changed the title
aduh95
reviewed
Mar 20, 2021
benjamingr
approved these changes
Mar 20, 2021
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
author ready
jasnell
approved these changes
Mar 22, 2021
|
Landed in 6ea652d |
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2021
cleanup AbortSignal child_process code duplication PR-URL: #37823 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 24, 2021
cleanup AbortSignal child_process code duplication PR-URL: #37823 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans-up AbortSignal code duplication between fork/exec and spawn (which seem to share the same essential implementation). Removed
spawnWithSignal, and all logic is now inspawn.This PR does have two behaviour changes:
fork/execFile, where before forfork/execFilean abort caused an abort in next-tick, while now it'll callabortin the same tick (a pre-aborted signal still aborts in next-tick as before). The behaviour forspawnis unchanged.child.spawn()is called, so that ifchild.spawn()throws, the signal won't keep a reference to the "bad" child-process.