Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix legacy stability indicator display #37838

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 20, 2021

Now:

image

With this change:

image

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 20, 2021
@Trott Trott changed the title doc: fix broken legacy stability indicator display doc: fix legacy stability indicator display Mar 20, 2021
@Trott Trott force-pushed the broken-banner-scene branch from 2ac13b8 to daa9c9e Compare March 20, 2021 13:36
PR-URL: nodejs#37838
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Trott Trott force-pushed the broken-banner-scene branch from daa9c9e to 7120411 Compare March 22, 2021 14:01
@Trott
Copy link
Member Author

Trott commented Mar 22, 2021

Landed in 7120411

@Trott Trott merged commit 7120411 into nodejs:master Mar 22, 2021
@Trott Trott deleted the broken-banner-scene branch March 22, 2021 14:01
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
PR-URL: #37838
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37838
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants