Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix deprecation warning in test-doctool-html #37858

Merged
merged 1 commit into from
Mar 23, 2021
Merged

test: fix deprecation warning in test-doctool-html #37858

merged 1 commit into from
Mar 23, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 22, 2021

Option was renamed in mdast-util-to-hast v8.2.0.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Mar 22, 2021
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Mar 22, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2021
@jasnell
Copy link
Member

jasnell commented Mar 22, 2021

There doesn't appear to be a reason to make this one wait. Fast track? Please 👍🏻

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 22, 2021
@aduh95 @Trott
test: fix deprecation warning in test-doctool-html
0a77830 
PR-URL: nodejs#37858
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Mar 23, 2021

Landed in 0a77830

@Trott Trott merged commit 0a77830 into nodejs:master Mar 23, 2021
@aduh95 aduh95 deleted the allow-scary-html branch March 23, 2021 13:59
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@aduh95 @ruyadorno
test: fix deprecation warning in test-doctool-html
86bf341 
PR-URL: #37858
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
test: fix deprecation warning in test-doctool-html
939f554 
PR-URL: #37858
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @jasnell @Trott @lpinca @richardlau @marsonya @nodejs-github-bot