Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add OpenSSL 3.0 checks #37860

Closed
wants to merge 2 commits into from
Closed

Commits on Mar 22, 2021

  1. test: add OpenSSL 3.0 checks to test-crypto-keygen

    Currently test-crypto-keygen.js fails when dynamically linking against
    OpenSSL 3.0 which the following error:
    === debug test-crypto-keygen ===
    Path: parallel/test-crypto-keygen
    node:assert:901
        throw newErr;
        ^
    AssertionError [ERR_ASSERTION]: ifError got unwanted exception:
    error:05000072:dsa routines::bad ffc parameters
    at DsaKeyPairGenJob.<anonymous>
      (/nodejs/openssl/test/common/index.js:342:12)
    at DsaKeyPairGenJob.<anonymous> (/openssl/test/common/index.js:379:15)
    at DsaKeyPairGenJob.job.ondone (node:internal/crypto/keygen:77:23)
     {
      generatedMessage: false,
      code: 'ERR_ASSERTION',
      actual: [Error: error:05000072:dsa routines::bad ffc parameters],
      expected: null,
      operator: 'ifError'
    }
    Command: node /nodejs/openssl/test/parallel/test-crypto-keygen.js
    
    This commit adds a check and adjusts the modulus length when linking
    against OpenSSL 3.0.
    danbev committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    5b6adb5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a00d23c View commit details
    Browse the repository at this point in the history