-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix "the the" typo in README.md of cjs-module-lexer #37895
doc: fix "the the" typo in README.md of cjs-module-lexer #37895
Conversation
/cc @guybedford |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs to be accepted upstream first (at https://github.com/guybedford/cjs-module-lexer) before it can land here.
Hi @aduh95 , changes was applied on cjs-module-lexer repository. Would you reconsider your review? Tnx |
@peZhmanParsaee We tend not to make changes to the parts in |
Thanks a lot for taking the time to send the PR upstream. Guy has indicated in nodejs/cjs-module-lexer#48 (comment) that there's likely no upcoming release in the near future, so I suppose it is fine to land this here before it's officially released upstream. I'll try to take care of this early next week. |
Thanks a lot dude |
Original commit message: fix "the the" typo in README.md file Refs: nodejs/cjs-module-lexer@22093e7 PR-URL: nodejs#37895 Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
45dc755
to
d7b8638
Compare
Landed in d7b8638. Thanks for your contribution :) |
Original commit message: fix "the the" typo in README.md file Refs: nodejs/cjs-module-lexer@22093e7 PR-URL: #37895 Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
No description provided.