test: split promisified timers test for coverage purposes #37943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
s/proimisifed/promisified/ |
Trott
changed the title
Trott
force-pushed
the
timers-promisified-coverage
branch
from
141c41e
to
cea86a0
Compare
@targos Fixed. Thanks! |
|
s/promisifed/promisified/ ? |
jasnell
approved these changes
Mar 27, 2021
Trott
changed the title
Trott
force-pushed
the
timers-promisified-coverage
branch
from
cea86a0
to
64e076e
Compare
Yikes. Fixed (again). Thanks. |
RaisinTen
added
the
author ready
targos
approved these changes
Mar 29, 2021
Because of lazy loading, running promisified timers tests for setTimeout and setImmediate from the same file means that there is a piece of code that doesn't get covered. Split into separate files to cover everything. Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/timers.js.html#L269 PR-URL: nodejs#37943 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Trott
force-pushed
the
timers-promisified-coverage
branch
from
64e076e
to
52c7539
Compare
|
Landed in 52c7539 |
ruyadorno
pushed a commit
that referenced
this pull request
Mar 30, 2021
Because of lazy loading, running promisified timers tests for setTimeout and setImmediate from the same file means that there is a piece of code that doesn't get covered. Split into separate files to cover everything. Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/timers.js.html#L269 PR-URL: #37943 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of lazy loading, running promisified timers tests for setTimeout
and setImmediate from the same file means that there is a piece of code
that doesn't get covered. Split into separate files to cover everything.
Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/timers.js.html#L269