Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve Buffer's encoding documentation #37945

Closed
wants to merge 1 commit into from
Closed

doc: improve Buffer's encoding documentation #37945

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 27, 2021

  • Add a paragraph about case-insensitivity of encoding options.
  • Document "utf-8", "utf-16le" and "ucs-2" aliases.
  • Always use "utf8" in documentation for defaults and examples.

@targos
doc: improve Buffer's encoding documentation
7d755f7 
- Add a paragraph about case-insensitivity of encoding options.
- Document "utf-8", "utf-16le" and "ucs-2" aliases.
- Always use "utf8" in documentation for defaults and examples.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 27, 2021
@targos targos mentioned this pull request Mar 27, 2021
Closed
@targos targos added the buffer Issues and PRs related to the buffer subsystem. label Mar 27, 2021
@targos
Copy link
Member Author

targos commented Mar 31, 2021

Landed in 5c367e1

@targos targos closed this Mar 31, 2021
@targos targos deleted the doc-utf8 branch March 31, 2021 16:20
targos added a commit that referenced this pull request Mar 31, 2021
@targos
doc: improve Buffer's encoding documentation
5c367e1 
- Add a paragraph about case-insensitivity of encoding options.
- Document "utf-8", "utf-16le" and "ucs-2" aliases.
- Always use "utf8" in documentation for defaults and examples.

PR-URL: #37945
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@targos @MylesBorins
doc: improve Buffer's encoding documentation
a57dc06 
- Add a paragraph about case-insensitivity of encoding options.
- Document "utf-8", "utf-16le" and "ucs-2" aliases.
- Always use "utf8" in documentation for defaults and examples.

PR-URL: #37945
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @jasnell @lpinca @cjihrig @aduh95 @marsonya @nodejs-github-bot