Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: use correct webcrypto RSASSA-PKCS1-v1_5 algorithm name #38029

Closed
wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Apr 1, 2021

This fixes the algorithm name used in Web Cryptography API.

Correct value is RSASSA-PKCS1-v1_5. The difference is lowercase "v" instead of uppercase "V".

Ref: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1

@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Apr 1, 2021
@panva panva requested a review from jasnell April 1, 2021 20:09
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 1, 2021
@nodejs-github-bot
Copy link
Collaborator

@panva
Copy link
Member Author

panva commented Apr 1, 2021

cc @nodejs/crypto

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Apr 1, 2021
@panva
Copy link
Member Author

panva commented Apr 1, 2021

@jasnell what am i missing here? why are the string changes not enough?

Edit: I see now:

  return { ...algorithm, name: StringPrototypeToUpperCase(name), hash };

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

panva added a commit that referenced this pull request Apr 3, 2021
PR-URL: #38029
Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva
Copy link
Member Author

panva commented Apr 3, 2021

Landed in c81d0fa

@panva panva closed this Apr 3, 2021
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
PR-URL: #38029
Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
MylesBorins pushed a commit that referenced this pull request Apr 5, 2021
PR-URL: #38029
Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva panva deleted the fix-rsa1_5-algorithm branch October 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants