Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check the different error code on IBM i #38159

Closed
wants to merge 1 commit into from
Closed

test: check the different error code on IBM i #38159

wants to merge 1 commit into from

Conversation

dmabupt
Copy link
Contributor

@dmabupt dmabupt commented Apr 9, 2021

Fixes: #36925

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 9, 2021
@dmabupt dmabupt added the ibm i Issues and PRs related to the IBM i platform. label Apr 9, 2021
cjihrig
cjihrig approved these changes Apr 9, 2021
View reviewed changes
test/parallel/test-fs-read-type.js
@@ -118,7 +118,10 @@ fs.read(fd,
2n ** 53n - 1n,
common.mustCall((err) => {
if (err) {
assert.strictEqual(err.code, 'EFBIG');
if (common.isIBMi)
assert.strictEqual(err.errno, -127);
Copy link
Contributor

@cjihrig cjihrig Apr 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error does 127 map to on IBM i? Should we try to map it in libuv?

Copy link
Contributor Author

@dmabupt dmabupt Apr 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is EOVERFLOW

$ grep 127 /usr/include/errno.h 
#define EOVERFLOW       127     /* value too large to be stored in data type */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error does 127 map to on IBM i? Should we try to map it in libuv?

@cjihrig PR to add a mapping for EOVERFLOW: libuv/libuv#3145

@dmabupt
Copy link
Contributor Author

dmabupt commented Apr 9, 2021 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-commit-ibmi/329/
Test fs_read_type passed - https://ci.nodejs.org/job/node-test-commit-ibmi/329/nodes=ibmi72-ppc64/testReport/(root)/test/parallel_test_fs_read_type/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37323/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37328/

RaisinTen added a commit to RaisinTen/libuv that referenced this pull request Apr 9, 2021
@RaisinTen
include: add EOVERFLOW status code mapping
3774ea5 
Refs: nodejs/node#38159 (comment)
@RaisinTen RaisinTen mentioned this pull request Apr 9, 2021
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37332/

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2021
dmabupt added a commit that referenced this pull request Apr 12, 2021
@dmabupt
test: check the different error code on IBM i
db9cf52 
Fixes: #36925

PR-URL: #38159
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@dmabupt
Copy link
Contributor Author

dmabupt commented Apr 12, 2021

landed in db9cf52

@dmabupt dmabupt closed this Apr 12, 2021
@dmabupt dmabupt deleted the ibmi_test_fs_read_type branch April 12, 2021 02:49
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
vtjnash pushed a commit to libuv/libuv that referenced this pull request May 13, 2021
@RaisinTen
include: add EOVERFLOW status code mapping
9739400 
Refs: nodejs/node#38159 (comment)
PR-URL: #3145
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
RaisinTen added a commit to RaisinTen/node that referenced this pull request May 13, 2021
@RaisinTen
test: use error code mapping in place of raw errno
eb85c63 
Refs: nodejs#38159 (comment)
@RaisinTen RaisinTen mentioned this pull request May 13, 2021
Closed
RaisinTen added a commit to RaisinTen/node that referenced this pull request Aug 7, 2021
@RaisinTen
test: use error code mapping in place of raw errno
046c8ab 
Refs: nodejs#38159 (comment)
RaisinTen added a commit to RaisinTen/node that referenced this pull request Aug 22, 2021
@RaisinTen
test: use error code mapping in place of raw errno
7c8156d 
Refs: nodejs#38159 (comment)
jasnell pushed a commit that referenced this pull request Aug 28, 2021
@RaisinTen @jasnell
test: use error code mapping in place of raw errno
21cf618 
Refs: #38159 (comment)

PR-URL: #38675
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
@RaisinTen @targos
test: use error code mapping in place of raw errno
bd80966 
Refs: #38159 (comment)

PR-URL: #38675
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
@RaisinTen @targos
test: use error code mapping in place of raw errno
007e285 
Refs: #38159 (comment)

PR-URL: #38675
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
JeffroMF pushed a commit to JeffroMF/libuv that referenced this pull request May 16, 2022
@RaisinTen @JeffroMF
include: add EOVERFLOW status code mapping
74a85a5 
Refs: nodejs/node#38159 (comment)
PR-URL: libuv#3145
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-fs-read-type fails on IBM i
6 participants
@dmabupt @nodejs-github-bot @cjihrig @richardlau @RaisinTen @targos