Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: validate encoding to binding.writeString() #38183

Merged
merged 1 commit into from
Apr 12, 2021
Merged

fs: validate encoding to binding.writeString() #38183

merged 1 commit into from
Apr 12, 2021

Commits on Apr 12, 2021

  1. fs: validate encoding to binding.writeString() 

    The binding layer performs some validation of the encoding and
data passed to WriteString(). This commit adds similar validation
to the JS layer for better error handling.

PR-URL: nodejs#38183
Fixes: nodejs#38168
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    @cjihrig
    cjihrig committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    8e76397 View commit details
    Browse the repository at this point in the history