Commits on Apr 21, 2021

1. tools: fix type mismatch in test runner …

   `output.diagnostic` is a list that is appended to on SmartOS when
   retrying a test due to `ECONNREFUSED`. The test runner checks if
   `output.diagnostic` is truthy and, if so, assigns its value to
   `self.traceback`. However `self.traceback` is supposed to be a string,
   and `_printDiagnostic()` in the `TapProgressIndicator` attempts to call
   `splitlines()` on it, which fails if it is a list with:
   AttributeError: 'list' object has no attribute 'splitlines'
   
   PR-URL: nodejs#38289
   Reviewed-By: Rich Trott <rtrott@gmail.com>
   Reviewed-By: Christian Clauss <cclauss@me.com>
   Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
   Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

   

   richardlau committed Apr 21, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for e703ceb
   • Browse repository at this point

   Copy the full SHA

   e703ceb View commit details

   Browse the repository at this point in the history