Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix setting Converter sub char length #38331

Closed
wants to merge 1 commit into from
Closed

src: fix setting Converter sub char length #38331

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 21, 2021

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #38330

@jasnell
src: fix setting Converter sub char length
cbc5f06 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#38330
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 21, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37642/

@jasnell jasnell mentioned this pull request Apr 23, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37649/

targos pushed a commit that referenced this pull request Apr 24, 2021
@jasnell @targos
src: fix setting Converter sub char length
639fa32 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38330

PR-URL: #38331
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos
Copy link
Member

targos commented Apr 24, 2021

Landed in 639fa32

@targos targos closed this Apr 24, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
@jasnell @targos
src: fix setting Converter sub char length
09cacd7 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38330

PR-URL: #38331
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@jasnell @targos
src: fix setting Converter sub char length
89fe999 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38330

PR-URL: #38331
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell @targos
src: fix setting Converter sub char length
6c2bf06 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38330

PR-URL: #38331
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@jasnell @targos
src: fix setting Converter sub char length
d177541 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38330

PR-URL: #38331
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buffer.transcode results in an abort
5 participants
@jasnell @nodejs-github-bot @targos @benjamingr @juanarbol