Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix abort in pbkdf2 #38354

Closed
wants to merge 1 commit into from
Closed

src: fix abort in pbkdf2 #38354

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This should be fixed in more places where double formatting is an issue.

cc @panva

Fixes: #38341

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 22, 2021
@tniessen tniessen mentioned this pull request Apr 22, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37611/

@panva panva mentioned this pull request Apr 22, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37614/

@tniessen tniessen removed the needs-ci PRs that need a full CI run. label Apr 22, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37617/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37628/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37631/

panva pushed a commit that referenced this pull request Apr 24, 2021
@tniessen @panva
src: fix abort in pbkdf2
81d7e80 
Fixes: #38341

PR-URL: #38354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@panva
Copy link
Member

panva commented Apr 24, 2021

Landed in 81d7e80

@panva panva closed this Apr 24, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
@tniessen @targos
src: fix abort in pbkdf2
e3538bb 
Fixes: #38341

PR-URL: #38354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
@tniessen tniessen deleted the src-fix-crash-formatting branch October 7, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crypto.pbkdf2Sync results in an abort
7 participants
@tniessen @nodejs-github-bot @panva @jasnell @addaleax @cjihrig @targos