Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: add JSDoc typings for inspector #38390

Closed
wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

@VoltrexKeyva VoltrexKeyva commented Apr 24, 2021

Added JSDoc typings for the inspector lib module.

@targos targos added typings inspector Issues and PRs related to the V8 inspector protocol labels Apr 25, 2021
@nodejs-github-bot
Copy link
Collaborator

lib/inspector.js Outdated Show resolved Hide resolved
lib/inspector.js Outdated Show resolved Hide resolved
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2021
@VoltrexKeyva VoltrexKeyva force-pushed the patch-1 branch 2 times, most recently from 48bc801 to 436925e Compare October 29, 2021 06:53
Added JSDoc typings for the `inspector` lib module.
targos pushed a commit that referenced this pull request Oct 31, 2021
Added JSDoc typings for the `inspector` lib module.

PR-URL: #38390
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Oct 31, 2021

Landed in 8768012

@targos targos closed this Oct 31, 2021
@VoltrexKeyva VoltrexKeyva deleted the patch-1 branch October 31, 2021 15:19
targos pushed a commit that referenced this pull request Nov 6, 2021
Added JSDoc typings for the `inspector` lib module.

PR-URL: #38390
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
Added JSDoc typings for the `inspector` lib module.

PR-URL: #38390
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants