Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 9.0.257.24 #38423

Closed
wants to merge 1 commit into from
Closed

Conversation

targos
Copy link
Member

@targos targos commented Apr 26, 2021

@github-actions github-actions bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 26, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2021

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2021
@jasnell
Copy link
Member

jasnell commented Apr 28, 2021

Landed in 8b60369

@jasnell jasnell closed this Apr 28, 2021
jasnell pushed a commit that referenced this pull request Apr 28, 2021
Refs: v8/v8@9.0.257.21...9.0.257.24

PR-URL: #38423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos deleted the v8-9.0.257.24 branch April 28, 2021 20:48
targos added a commit that referenced this pull request Apr 29, 2021
Refs: v8/v8@9.0.257.21...9.0.257.24

PR-URL: #38423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 3, 2021
@zsims
Copy link

zsims commented May 11, 2021

@targos when will this land in a v14 LTS release? Per https://github.com/nodejs/Release there should be a minor semver patch?

@tchetwin
Copy link

@zsims is this what you're looking for? 6b115d7

Available in 14.17.0 as of 2021-05-11 (possibly right after your comment!)

@zsims
Copy link

zsims commented May 12, 2021

@tchetwin Exactly what I'm looking for. Thanks for your work on this + the release :-)

@zsims
Copy link

zsims commented May 12, 2021

@tchetwin I would have expected to see v8/v8@df40e08 (as in this PR). Will this be making it to v14 LTS?

@zsims
Copy link

zsims commented May 25, 2021

@tchetwin any updates for when/if v8/v8@df40e08 (in this PR) will land in v14 LTS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants